LGTM with a nit.

https://chromiumcodereview.appspot.com/11472023/diff/1/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/11472023/diff/1/build/common.gypi#newcode147
build/common.gypi:147: [ 'v8_can_use_vfp2_instructions=="true" or
arm_neon==1 or arm_fpu=="vfpv3" or arm_fpu=="vfpv3-d16"', {
nit: 80 columns please. You can use \ at the end of the line.

Again below.

https://chromiumcodereview.appspot.com/11472023/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to