LGTM if comments are addressed.
https://codereview.chromium.org/11478043/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): https://codereview.chromium.org/11478043/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode1229 src/ia32/lithium-codegen-ia32.cc:1229: if (test_value != 0) { this if-block seems also unnecessary if divisor is -1 or 1 https://codereview.chromium.org/11478043/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): https://codereview.chromium.org/11478043/diff/1/src/x64/lithium-codegen-x64.cc#newcode1161 src/x64/lithium-codegen-x64.cc:1161: if (test_value != 0) { Ditto. https://codereview.chromium.org/11478043/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
