LGTM (with a nit).
https://codereview.chromium.org/11530011/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/11530011/diff/1/src/runtime.cc#newcode13115 src/runtime.cc:13115: ASSERT_EQ(args.length(), 1); This method should either have a NoHandleAllocation scope or it's own HandleScope. https://codereview.chromium.org/11530011/diff/1/src/runtime.cc#newcode13128 src/runtime.cc:13128: ASSERT_EQ(args.length(), 2); Likewise. https://codereview.chromium.org/11530011/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
