Feedback addressed, I'll land this when the branch has been cut.
https://codereview.chromium.org/11528003/diff/2001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/11528003/diff/2001/src/hydrogen-instructions.h#newcode1947 src/hydrogen-instructions.h:1947: SetOperandAt(1, typecheck != NULL ? typecheck : value); Landed the other patch first, rebased on it. On 2012/12/11 14:05:54, Jakob wrote:
I could swear I've reviewed this change before... ah, yes: https://codereview.chromium.org/11464027/
https://codereview.chromium.org/11528003/diff/2001/src/ia32/macro-assembler-ia32.h File src/ia32/macro-assembler-ia32.h (right): https://codereview.chromium.org/11528003/diff/2001/src/ia32/macro-assembler-ia32.h#newcode61 src/ia32/macro-assembler-ia32.h:61: void IterateCompiledFrame(const StandardFrame* frame, ObjectVisitor* v); On 2012/12/11 14:05:54, Jakob wrote:
We #include frames.h above, which contains an identical declaration
(except for
"const"). Can you get rid of this line by moving the constness into
the
declaration in frames.h?
Same for the other platforms.
Done. https://codereview.chromium.org/11528003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
