LGTM.
https://codereview.chromium.org/11412310/diff/2001/test/mjsunit/debug-set-variable-value.js File test/mjsunit/debug-set-variable-value.js (right): https://codereview.chromium.org/11412310/diff/2001/test/mjsunit/debug-set-variable-value.js#newcode128 test/mjsunit/debug-set-variable-value.js:128: ClosureTestCase.prototype.run_and_catch_ = function(runnable) { On 2012/12/11 23:20:44, Peter Rybin wrote:
On 2012/12/10 14:15:11, Yang wrote: > Why does this end with an underscore?
I mean it a private member.
Well, javascript doesn't really have a private concept. But I guess you can keep it this way if you insist. https://codereview.chromium.org/11412310/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
