Quick DBC...

https://chromiumcodereview.appspot.com/11547015/diff/4010/src/deoptimizer.h
File src/deoptimizer.h (right):

https://chromiumcodereview.appspot.com/11547015/diff/4010/src/deoptimizer.h#newcode90
src/deoptimizer.h:90: class OptimizedFunctionFilter BASE_EMBEDDED {
This is what is commonly called a predicate (even in STL ;-), and it
might be nicer to move this in a templatized version to utils.h. Perhaps
we should even add a unary_function template there from which can
subclass. OptimizedFunctionFilter can be a typedef if it is needed at
all then.

Anyway, overloading function invocation (i.e. operator()) seems to be
more natural than making up a name like TakeFunction.

https://chromiumcodereview.appspot.com/11547015/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to