LGTM (with comments for the predicate in LookupResult). Adding Sven.
https://codereview.chromium.org/11554019/diff/1/src/property.h File src/property.h (right): https://codereview.chromium.org/11554019/diff/1/src/property.h#newcode320 src/property.h:320: return GetCallbackObject()->IsForeign(); I think AccessorInfo callbacks should also return true here, they also look like data properties to JavaScript. https://codereview.chromium.org/11554019/diff/1/src/property.h#newcode321 src/property.h:321: default: I think Sven has to say something about this default case. https://codereview.chromium.org/11554019/diff/1/src/v8natives.js File src/v8natives.js (right): https://codereview.chromium.org/11554019/diff/1/src/v8natives.js#newcode896 src/v8natives.js:896: // TODO(mstarzinger): This hack should be removed once we have addressed the Interesting, TODO with my name popping out of thin air. Strange. :) https://codereview.chromium.org/11554019/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
