LGTM with a nit
https://codereview.chromium.org/11567007/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/11567007/diff/1/src/objects.h#newcode761 src/objects.h:761: inline void Name##Print() { Name##Print(stdout); } \ Drop this... https://codereview.chromium.org/11567007/diff/1/src/objects.h#newcode762 src/objects.h:762: void Name##Print(FILE* out); ... and use "FILE* out = stdout" here, it's cleaner! ;-) https://codereview.chromium.org/11567007/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
