On 2012/12/13 02:20:43, apaprocki wrote:
Updated the patch according to comments.

Rather than duplicate the guts of StackGuard::Continue() inside
StackGuard::ResumeExecution(), I just call Continue(TERMINATE) there instead
since the ExecutionAccess guard is recursive.

The TERMINATE flag must be cleared at this point so that when
Execution::HandleStackGuardInterrupt() runs,
stack_guard->IsTerminateException()
returns false.

LGTM. But before I land this, I'd like to clear up one thing: what is the
affiliation with Bloomberg Finance L.P.? I have checked and don't see Bloomberg
Finance L.P. registered as have signed the corporate CLA. You however are,
registered as individual. I'm sort of confused.

https://codereview.chromium.org/11142013/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to