Apart from the comments below, I have trouble understanding what the point
of
the whole CL is: What problem exactly is it trying to solve?
https://codereview.chromium.org/11566011/diff/6001/src/deoptimizer.h
File src/deoptimizer.h (right):
https://codereview.chromium.org/11566011/diff/6001/src/deoptimizer.h#newcode105
src/deoptimizer.h:105: #if defined(V8_TARGET_ARCH_X64)
Having architecture-specific stuff here in the architecture-independent
parts is the wrong approach, leading into the wrong direction. I would
strongly object any such change...
Our goal should be making the deoptimizer code more
architecture-independent, we already have *tons* of duplicated
boilerplate code.
https://codereview.chromium.org/11566011/diff/6001/src/deoptimizer.h#newcode434
src/deoptimizer.h:434: #if V8_TARGET_ARCH_MIPS
Not from this CL, but the same comment holds. This should be
moved/refactored.
https://codereview.chromium.org/11566011/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
