LGTM, but please address comments before I land this CL.
https://codereview.chromium.org/11573017/diff/1/src/mips/codegen-mips.cc File src/mips/codegen-mips.cc (right): https://codereview.chromium.org/11573017/diff/1/src/mips/codegen-mips.cc#newcode550 src/mips/codegen-mips.cc:550: // Smis are tagged by left shift by 1, thus LSR by 1 to smi-untag inline. This comment does not apply to MIPS. https://codereview.chromium.org/11573017/diff/1/src/mips/codegen-mips.cc#newcode551 src/mips/codegen-mips.cc:551: __ srl(at, index, 1); Isn't there a SmiUntag macro for MIPS as well? https://codereview.chromium.org/11573017/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
