Adding jkummerow@ who should review the build system changes (unfortunately, he's on vacation until the new year).
https://codereview.chromium.org/11574031/diff/1/src/v8.cc File src/v8.cc (right): https://codereview.chromium.org/11574031/diff/1/src/v8.cc#newcode90 src/v8.cc:90: if (i::FLAG_jit_profile) My primary feedback about this patch is that the enabling of VTune profiling should be a decision for the embedder, i.e. D8 or Chromium. You might want to include a utility file in the vtune directory that calls V8::Initialize and then immediately afterwards "v8::V8::SetJitCodeEventHandler(v8::kJitCodeEventDefault, i::VTUNEJITInterface::event_handler);" You can then move the initialization to D8 with the appropriate build flags. You will have to provide a patch to Chromium, too. https://codereview.chromium.org/11574031/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
