[v8-dev] Refactoring only: Use CheckSSE2OperandIsInt32 instead of copy-n-paste code. (issue 11666004)

Fri, 21 Dec 2012 01:40:38 -0800 

Reviewers: Yang,

Description:
Refactoring only: Use CheckSSE2OperandIsInt32 instead of copy-n-paste code.


Please review this at https://codereview.chromium.org/11666004/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
  M src/ia32/code-stubs-ia32.cc


Index: src/ia32/code-stubs-ia32.cc
diff --git a/src/ia32/code-stubs-ia32.cc b/src/ia32/code-stubs-ia32.cc
index 23dfc24b6e9d3f12897b23ad33fe11751896b7ff..6114da947c7d82548c1ddb20b39cb3ca63f1ffcc 100644 
--- a/src/ia32/code-stubs-ia32.cc
+++ b/src/ia32/code-stubs-ia32.cc
@@ -1757,12 +1757,8 @@ void BinaryOpStub::GenerateInt32Stub(MacroAssembler* masm) { 
           }
           // Check result type if it is currently Int32.
           if (result_type_ <= BinaryOpIC::INT32) {
-            __ cvttsd2si(ecx, Operand(xmm0));
-            __ cvtsi2sd(xmm2, ecx);
-            __ pcmpeqd(xmm2, xmm0);
-            __ movmskpd(ecx, xmm2);
-            __ test(ecx, Immediate(1));
-            __ j(zero, &not_int32);
+            FloatingPointHelper::CheckSSE2OperandIsInt32(
+                masm, &not_int32, xmm0, ecx, xmm2);
           }
BinaryOpStub_GenerateHeapResultAllocation(masm, &call_runtime, mode_); 
           __ movdbl(FieldOperand(eax, HeapNumber::kValueOffset), xmm0);


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to