This is a good idea, and thanks for all your work trying to untangle this RelocInfo business, I think you're almost there.
I'd ask you to please alter the code coverage macro even though it might appear
to be broken, i.e. masm->movq(rax, reinterpret_cast<int64_t>(x64_coverage_function), RelocInfo::EXTERNAL_REFERENCE) masm->call(eax); instead of masm->call(x64_coverage_function, RelocInfo::RUNTIME_ENTRY); That way it's at least not more broken than it already is. https://codereview.chromium.org/11694008/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
