LGTM with comments.
https://codereview.chromium.org/11644097/diff/1/src/arm/simulator-arm.cc File src/arm/simulator-arm.cc (right): https://codereview.chromium.org/11644097/diff/1/src/arm/simulator-arm.cc#newcode3087 src/arm/simulator-arm.cc:3087: dst, static_cast<double>(reinterpret_cast<uint32_t>(val))); Shouldn't this be a static_cast? https://codereview.chromium.org/11644097/diff/1/src/arm/simulator-arm.cc#newcode3094 src/arm/simulator-arm.cc:3094: dst, static_cast<float>(reinterpret_cast<uint32_t>(val))); Likewise. https://codereview.chromium.org/11644097/diff/1/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): https://codereview.chromium.org/11644097/diff/1/test/cctest/test-heap.cc#newcode168 test/cctest/test-heap.cc:168: HEAP->NumberFromUint32(static_cast<uint32_t>(1) << 31); Should fit into one line. https://codereview.chromium.org/11644097/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
