lgtm with nits

https://codereview.chromium.org/11775016/diff/1/src/data-flow.h
File src/data-flow.h (right):

https://codereview.chromium.org/11775016/diff/1/src/data-flow.h#newcode229
src/data-flow.h:229: void Union(const GrowableBitVector& other, Zone*
zone) {
I'd prefer keeping the original AddAll name (in the client of this
method). Union sounds like it would return a new vector as the union of
both arguments.

Could possibly EnsureCapacity(other->Length());

https://codereview.chromium.org/11775016/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to