On 2013/01/09 09:09:40, Michael Starzinger wrote:
LGTM (with a nit).
https://codereview.chromium.org/11828014/diff/1/src/runtime.h File src/runtime.h (right):
https://codereview.chromium.org/11828014/diff/1/src/runtime.h#newcode377 src/runtime.h:377: F(FlattenString, 1, 1) \ Nit of the day: I think this better fits into the /* Utilities */ category further up.
drive-by: test/mjsunit/substr.js uses /x/ to flatten. Replace there too? There
are probably more places like this. https://codereview.chromium.org/11828014/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
