https://codereview.chromium.org/11377135/diff/10001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/11377135/diff/10001/src/hydrogen-instructions.h#newcode1032 src/hydrogen-instructions.h:1032: set_representation(Representation::Tagged()); Can you add a comment here that explains why you use HType::Smi, i.e. explain that you want to minimize the expense of inserted changes? https://codereview.chromium.org/11377135/diff/10001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/11377135/diff/10001/src/hydrogen.cc#newcode1263 src/hydrogen.cc:1263: void HGraph::NullifyUnreachableInstructions() { Can you skip this pass all together if there are no soft deopts and a situation hasn't occurred during MarkAsDeoptimizingRecursively() where all_predecessors_deoptimizing is true? https://codereview.chromium.org/11377135/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
