[v8-dev] Make v8 handle OOM during Heap construction more gracefully. (issue 11824064)

[svenpanne]

Reviewers: Jakob,

Description:
Make v8 handle OOM during Heap construction more gracefully.

Please review this at https://codereview.chromium.org/11824064/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
  M src/api.cc
  M src/isolate.cc


Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index  
352b63dfcac810c01a743edbac698a77214da53c..0563443b8bdf1248a2b3bf78bd837bceb406c6d2  
100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -128,8 +128,13 @@ namespace v8 {

 static void DefaultFatalErrorHandler(const char* location,
                                      const char* message) {
-  i::VMState __state__(i::Isolate::Current(), i::OTHER);
-  API_Fatal(location, message);
+  i::Isolate* isolate = i::Isolate::Current();
+  if (isolate->IsInitialized()) {
+    i::VMState __state__(isolate, i::OTHER);
+    API_Fatal(location, message);
+  } else {
+    API_Fatal(location, message);
+  }
 }


@@ -202,15 +207,21 @@ void i::V8::FatalProcessOutOfMemory(const char*  
location, bool take_snapshot) {
   int end_marker;
   heap_stats.end_marker = &end_marker;
   i::Isolate* isolate = i::Isolate::Current();
-  // BUG(1718):
-  // Don't use the take_snapshot since we don't support HeapIterator here
-  // without doing a special GC.
-  isolate->heap()->RecordStats(&heap_stats, false);
+  if (isolate->heap()->HasBeenSetUp()) {
+    // BUG(1718): Don't use the take_snapshot since we don't support
+    // HeapIterator here without doing a special GC.
+    isolate->heap()->RecordStats(&heap_stats, false);
+  }
   i::V8::SetFatalError();
   FatalErrorCallback callback = GetFatalErrorHandler();
+  const char* message = "Allocation failed - process out of memory";
   {
-    LEAVE_V8(isolate);
-    callback(location, "Allocation failed - process out of memory");
+    if (isolate->IsInitialized()) {
+      LEAVE_V8(isolate);
+      callback(location, message);
+    } else {
+      callback(location, message);
+    }
   }
   // If the callback returns, we stop execution.
   UNREACHABLE();
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index  
c1360691a69213fc24b3440e052cd0f6aadbb268..2044805ca90f384e425265378bec18d2e621fd59  
100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -2003,7 +2003,7 @@ bool Isolate::Init(Deserializer* des) {
   const bool create_heap_objects = (des == NULL);
   ASSERT(!heap_.HasBeenSetUp());
   if (!heap_.SetUp(create_heap_objects)) {
-    V8::SetFatalError();
+    V8::FatalProcessOutOfMemory("heap setup");
     return false;
   }



--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev