PTAL.
https://codereview.chromium.org/11818052/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/11818052/diff/1/src/mark-compact.cc#newcode946 src/mark-compact.cc:946: SharedFunctionInfo* next_candidate; On 2013/01/11 10:09:51, Hannes Payer wrote:
Why is there a difference between shared_info being the head of the
list and
being somewhere on the list? Moreover can you unify the code below?
The head needs to be handles specially, because it is stored as a field inside the code-flusher (i.e. in the shared_function_info_candidates_head_ field). https://codereview.chromium.org/11818052/diff/1/src/mark-compact.cc#newcode958 src/mark-compact.cc:958: ClearNextCandidate(shared_info); As discussed offline, I added a break here. https://codereview.chromium.org/11818052/diff/1/src/mark-compact.cc#newcode988 src/mark-compact.cc:988: ClearNextCandidate(function, undefined); Likewise. https://codereview.chromium.org/11818052/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
