https://codereview.chromium.org/11861006/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/11861006/diff/1/include/v8.h#newcode1122
include/v8.h:1122: int start = 0,
On 2013/01/11 14:06:33, Michael Starzinger wrote:
Indentation is off.

Done.

https://codereview.chromium.org/11861006/diff/1/include/v8.h#newcode1127
include/v8.h:1127: int start = 0,
On 2013/01/11 14:06:33, Michael Starzinger wrote:
Likewise.

Done.

https://codereview.chromium.org/11861006/diff/1/include/v8.h#newcode1132
include/v8.h:1132: int length = -1,
On 2013/01/11 14:06:33, Michael Starzinger wrote:
Likewise.

Done.

https://codereview.chromium.org/11861006/diff/1/include/v8.h#newcode1249
include/v8.h:1249: const ExternalAsciiStringResource*
GetExternalAsciiStringResource()
On 2013/01/11 14:06:33, Michael Starzinger wrote:
Fits into one line now.

Done.

https://codereview.chromium.org/11861006/diff/1/include/v8.h#newcode1396
include/v8.h:1396: Encoding encoding) const;
On 2013/01/11 14:06:33, Michael Starzinger wrote:
Indentation is off.

Done.

https://codereview.chromium.org/11861006/diff/1/include/v8.h#newcode4155
include/v8.h:4155: class V8EXPORT Internals {
On 2013/01/11 14:06:33, Michael Starzinger wrote:
This class should not be exported since it should not be used
externally.

Done.

https://codereview.chromium.org/11861006/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to