Generally LGTM, but I do have a question before landing this.
https://chromiumcodereview.appspot.com/11642006/diff/5001/tools/gyp/v8.gyp File tools/gyp/v8.gyp (right): https://chromiumcodereview.appspot.com/11642006/diff/5001/tools/gyp/v8.gyp#newcode1005 tools/gyp/v8.gyp:1005: 'variables': { I get that when copy-pasting, it's good to avoid having to manually adapt the pasted version, but: duplicate 'variables' sections? Are you sure this works as intended? https://chromiumcodereview.appspot.com/11642006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
