LGTM, but I got one comment.
https://codereview.chromium.org/11889007/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/11889007/diff/1/src/runtime.cc#newcode5910 src/runtime.cc:5910: if ((or_acc & kAsciiMask) != 0) { Would it be noticeably more expensive to do this check for every word instead of accumulating the words (bitwise-and, compare and jump as opposed to bitwise-or)? The tradeoff is that we can terminate early for the non-ascii case. https://codereview.chromium.org/11889007/diff/1/src/runtime.cc#newcode6001 src/runtime.cc:6001: if (is_ascii) { It looks like we could save time if Convert failed early if the result is not ascii. https://codereview.chromium.org/11889007/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
