On 2013/01/15 11:34:45, Sven Panne wrote:
Quick drive-by-comment: Every time a new instruction is added to the
assembler,
the disassembler *must* be changed to handle this as well...

Not in this case -- it's not a completely new instruction, just a new
combination of arguments. Our disassembler handles this without requiring
changes.

Patch set 2 LGTM.

https://codereview.chromium.org/11852007/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to