Revision: 13425
Author: [email protected]
Date: Fri Jan 18 02:40:43 2013
Log: Merged r13386 into 3.14 branch.
Fix arguments materialization for inlined apply().
[email protected]
BUG=v8:2489
TEST=mjsunit/regress/regress-2489
Review URL: https://codereview.chromium.org/11871012
http://code.google.com/p/v8/source/detail?r=13425
Added:
/branches/3.14/test/mjsunit/regress/regress-2489.js
Modified:
/branches/3.14/src/hydrogen-instructions.cc
/branches/3.14/src/hydrogen-instructions.h
/branches/3.14/src/hydrogen.cc
/branches/3.14/src/version.cc
=======================================
--- /dev/null
+++ /branches/3.14/test/mjsunit/regress/regress-2489.js Fri Jan 18 02:40:43
2013
@@ -0,0 +1,50 @@
+// Copyright 2013 the V8 project authors. All rights reserved.
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+// * Redistributions of source code must retain the above copyright
+// notice, this list of conditions and the following disclaimer.
+// * Redistributions in binary form must reproduce the above
+// copyright notice, this list of conditions and the following
+// disclaimer in the documentation and/or other materials provided
+// with the distribution.
+// * Neither the name of Google Inc. nor the names of its
+// contributors may be used to endorse or promote products derived
+// from this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+// Flags: --allow-natives-syntax
+
+"use strict";
+
+function f(a, b) {
+ return g("c", "d");
+}
+
+function g(a, b) {
+ g.constructor.apply(this, arguments);
+}
+
+g.constructor = function(a, b) {
+ assertEquals("c", a);
+ assertEquals("d", b);
+}
+
+f("a", "b");
+f("a", "b");
+%OptimizeFunctionOnNextCall(f);
+f("a", "b");
+g.x = "deopt";
+f("a", "b");
=======================================
--- /branches/3.14/src/hydrogen-instructions.cc Mon Oct 22 06:09:53 2012
+++ /branches/3.14/src/hydrogen-instructions.cc Fri Jan 18 02:40:43 2013
@@ -723,6 +723,13 @@
value()->PrintNameTo(stream);
stream->Add(", \"%o\")", *class_name());
}
+
+
+void HWrapReceiver::PrintDataTo(StringStream* stream) {
+ receiver()->PrintNameTo(stream);
+ stream->Add(" ");
+ function()->PrintNameTo(stream);
+}
void HAccessArgumentsAt::PrintDataTo(StringStream* stream) {
=======================================
--- /branches/3.14/src/hydrogen-instructions.h Mon Oct 22 06:09:53 2012
+++ /branches/3.14/src/hydrogen-instructions.h Fri Jan 18 02:40:43 2013
@@ -2760,6 +2760,8 @@
virtual HValue* Canonicalize();
+ virtual void PrintDataTo(StringStream* stream);
+
DECLARE_CONCRETE_INSTRUCTION(WrapReceiver)
};
=======================================
--- /branches/3.14/src/hydrogen.cc Mon Oct 15 04:51:39 2012
+++ /branches/3.14/src/hydrogen.cc Fri Jan 18 02:40:43 2013
@@ -7502,7 +7502,10 @@
return true;
} else {
// We are inside inlined function and we know exactly what is inside
- // arguments object.
+ // arguments object. But we need to be able to materialize at deopt.
+ // TODO(mstarzinger): For now we just ensure arguments are pushed
+ // right after HEnterInlined, but we could be smarter about this.
+ EnsureArgumentsArePushedForAccess();
HValue* context = environment()->LookupContext();
HValue* wrapped_receiver =
=======================================
--- /branches/3.14/src/version.cc Thu Dec 13 05:20:46 2012
+++ /branches/3.14/src/version.cc Fri Jan 18 02:40:43 2013
@@ -35,7 +35,7 @@
#define MAJOR_VERSION 3
#define MINOR_VERSION 14
#define BUILD_NUMBER 5
-#define PATCH_LEVEL 3
+#define PATCH_LEVEL 4
// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
#define IS_CANDIDATE_VERSION 0
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
