Reviewers: Toon Verwaest,
Message:
PTAL.
Description:
tools/runtests.py: Fix cctests on Windows; properly return error code when
there
were Python exceptions
Please review this at https://codereview.chromium.org/11929020/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M test/cctest/testcfg.py
M tools/testrunner/local/execution.py
Index: test/cctest/testcfg.py
diff --git a/test/cctest/testcfg.py b/test/cctest/testcfg.py
index
69a5db2044fdd94363a846b8d2489c68d5b9da13..1d03a845f53d0bd1f8bdb8c81c0e8bc66a74ddfd
100644
--- a/test/cctest/testcfg.py
+++ b/test/cctest/testcfg.py
@@ -45,9 +45,9 @@ class CcTestSuite(testsuite.TestSuite):
os.makedirs(self.serdes_dir)
def ListTests(self, context):
+ shell = os.path.abspath(os.path.join(context.shell_dir, self.shell()))
if utils.IsWindows():
shell += '.exe'
- shell = os.path.abspath(os.path.join(context.shell_dir, self.shell()))
output = commands.Execute([context.command_prefix,
shell,
'--list',
Index: tools/testrunner/local/execution.py
diff --git a/tools/testrunner/local/execution.py
b/tools/testrunner/local/execution.py
index
6004367913099c864a701ce094e7e1daf2ff7609..2e37fcbcdb1d9c9fb553881d464c0a3dc0d85f25
100644
--- a/tools/testrunner/local/execution.py
+++ b/tools/testrunner/local/execution.py
@@ -90,7 +90,7 @@ class Runner(object):
self.indicator.Starting()
self._RunInternal(jobs)
self.indicator.Done()
- if self.failed:
+ if self.failed or self.remaining:
return 1
return 0
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
