Reviewers: Michael Starzinger,

Message:
PTAL.

Description:
tools/run-tests.py: Fixes for Windows


Please review this at https://codereview.chromium.org/11926015/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
  M test/mjsunit/testcfg.py
  M tools/testrunner/local/testsuite.py
  M tools/testrunner/server/compression.py


Index: test/mjsunit/testcfg.py
diff --git a/test/mjsunit/testcfg.py b/test/mjsunit/testcfg.py
index c8b972c12f973e2425b3529a51bb615da44cfd45..00d4500f1c5e1bed10b9eef62a7b32fd2f529e8c 100644
--- a/test/mjsunit/testcfg.py
+++ b/test/mjsunit/testcfg.py
@@ -75,7 +75,7 @@ class MjsunitTestSuite(testsuite.TestSuite):
               for f in files_list ]
     testfilename = os.path.join(self.root, testcase.path + self.suffix())
     if SELF_SCRIPT_PATTERN.search(source):
-      env = ["-e", "TEST_FILE_NAME=\"%s\"" % testfilename]
+ env = ["-e", "TEST_FILE_NAME=\"%s\"" % testfilename.replace("\\", "\\\\")]
       files = env + files
     files.append(os.path.join(self.root, "mjsunit.js"))
     files.append(testfilename)
Index: tools/testrunner/local/testsuite.py
diff --git a/tools/testrunner/local/testsuite.py b/tools/testrunner/local/testsuite.py index de5cddd11501c5cf0a3f2261aeb2c19f59995d32..473e8b1efed2e4b860df31707b436b784f7b3654 100644
--- a/tools/testrunner/local/testsuite.py
+++ b/tools/testrunner/local/testsuite.py
@@ -30,6 +30,7 @@ import imp
 import os

 from . import statusfile
+from . import utils

 class TestSuite(object):

@@ -88,6 +89,8 @@ class TestSuite(object):
     used_rules = set()
     for t in self.tests:
       testname = self.CommonTestName(t)
+      if utils.IsWindows():
+        testname = testname.replace("\\", "/")
       if testname in self.rules:
         used_rules.add(testname)
         outcomes = self.rules[testname]
Index: tools/testrunner/server/compression.py
diff --git a/tools/testrunner/server/compression.py b/tools/testrunner/server/compression.py index ce90c4f5978139b0ec961919b688a56631ceed67..d5ed4159766ddbbb4a8f581759f2d98ae6728067 100644
--- a/tools/testrunner/server/compression.py
+++ b/tools/testrunner/server/compression.py
@@ -30,7 +30,6 @@ import cStringIO as StringIO
 try:
   import ujson as json
 except ImportError:
-  print("You should install UltraJSON, it is much faster!")
   import json
 import os
 import struct


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to