LGTM with nits.
https://chromiumcodereview.appspot.com/11973008/diff/3022/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): https://chromiumcodereview.appspot.com/11973008/diff/3022/src/arm/code-stubs-arm.cc#newcode4518 src/arm/code-stubs-arm.cc:4518: } else { Please add an ASSERT(kind_ == Code::LOAD_IC) for documentation purposes. (Same on x64.) https://chromiumcodereview.appspot.com/11973008/diff/3022/src/code-stubs.h File src/code-stubs.h (right): https://chromiumcodereview.appspot.com/11973008/diff/3022/src/code-stubs.h#newcode559 src/code-stubs.h:559: Code::Kind kind_; protected data members are frowned upon. Please make the field private and define a protected getter instead. https://chromiumcodereview.appspot.com/11973008/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
