LGTM with nits.Mechanical changes indeed -- I could almost write a small script that generates
the comments :-)
https://chromiumcodereview.appspot.com/11938013/diff/1/src/builtins.cc File src/builtins.cc (right): https://chromiumcodereview.appspot.com/11938013/diff/1/src/builtins.cc#newcode1456 src/builtins.cc:1456: static void Generate_LoadIC_FunctionPrototype(MacroAssembler* masm) { This is a Rietveld bug, right? https://chromiumcodereview.appspot.com/11938013/diff/1/src/code-stubs.h File src/code-stubs.h (right): https://chromiumcodereview.appspot.com/11938013/diff/1/src/code-stubs.h#newcode564 src/code-stubs.h:564: Code::Kind kind_; again, make the field private and define a protected getter, please. https://chromiumcodereview.appspot.com/11938013/diff/1/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): https://chromiumcodereview.appspot.com/11938013/diff/1/src/x64/code-stubs-x64.cc#newcode2374 src/x64/code-stubs-x64.cc:2374: } else { again, an ASSERT(kind() == Code::LOAD_IC) please. https://chromiumcodereview.appspot.com/11938013/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
