LGTM (with one comment about the API change).
https://codereview.chromium.org/11953043/diff/1/include/v8.h File include/v8.h (left): https://codereview.chromium.org/11953043/diff/1/include/v8.h#oldcode3219 include/v8.h:3219: static void SetGlobalGCPrologueCallback(GCCallback); I think it is better to mark this function as deprecated with the V8_DEPRECATED macro instead of removing it right away. It might brake other embedders. We'll do the cleanup part with the next milestone. https://codereview.chromium.org/11953043/diff/1/include/v8.h#oldcode3248 include/v8.h:3248: static void SetGlobalGCEpilogueCallback(GCCallback); Likewise. https://codereview.chromium.org/11953043/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
