Addressed comments. The code was mostly just moved yes. Only the header
(choosing incoming registers) and footer (IC miss generation) needed
adjustment.
https://chromiumcodereview.appspot.com/11896091/diff/1/src/ic.cc
File src/ic.cc (right):
https://chromiumcodereview.appspot.com/11896091/diff/1/src/ic.cc#newcode816
src/ic.cc:816: TRACE_IC("KeyedCallIC", key, state, target());
On 2013/01/25 11:38:57, Jakob wrote:
We should only TRACE_IC after setting a new target. Please move this
above the
'}'.
Done.
https://chromiumcodereview.appspot.com/11896091/diff/1/src/ic.cc#newcode1275
src/ic.cc:1275: TRACE_IC("KeyedLoadIC", key, state, target());
On 2013/01/25 11:38:57, Jakob wrote:
Same here. (Due to the conditions, this code actually does the right
thing
currently, but let's make it explicit nevertheless that TRACE_IC()
happens iff
set_target() was called.)
Done.
https://chromiumcodereview.appspot.com/11896091/diff/1/src/ic.cc#newcode1763
src/ic.cc:1763: TRACE_IC("KeyedStoreIC", key, state, target());
On 2013/01/25 11:38:57, Jakob wrote:
Again, please move this to right after set_target().
Done.
https://chromiumcodereview.appspot.com/11896091/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
