Revision: 13539
Author: [email protected]
Date: Tue Jan 29 05:27:23 2013
Log: Fix test harness to correctly split extra flags.
[email protected]
Review URL: https://codereview.chromium.org/12094032
http://code.google.com/p/v8/source/detail?r=13539
Modified:
/branches/bleeding_edge/test/cctest/testcfg.py
/branches/bleeding_edge/tools/run-tests.py
/branches/bleeding_edge/tools/testrunner/local/execution.py
=======================================
--- /branches/bleeding_edge/test/cctest/testcfg.py Wed Jan 23 03:41:56 2013
+++ /branches/bleeding_edge/test/cctest/testcfg.py Tue Jan 29 05:27:23 2013
@@ -49,9 +49,8 @@
if utils.IsWindows():
shell += ".exe"
output = commands.Execute(context.command_prefix +
- [shell,
- "--list",
- context.extra_flags])
+ [shell, "--list"] +
+ context.extra_flags)
if output.exit_code != 0:
print output.stdout
print output.stderr
=======================================
--- /branches/bleeding_edge/tools/run-tests.py Wed Jan 23 03:41:56 2013
+++ /branches/bleeding_edge/tools/run-tests.py Tue Jan 29 05:27:23 2013
@@ -178,6 +178,7 @@
"running tests locally.")
options.no_network = True
options.command_prefix = shlex.split(options.command_prefix)
+ options.extra_flags = shlex.split(options.extra_flags)
if options.j == 0:
options.j = multiprocessing.cpu_count()
if options.no_stress:
=======================================
--- /branches/bleeding_edge/tools/testrunner/local/execution.py Wed Jan 23
03:41:56 2013
+++ /branches/bleeding_edge/tools/testrunner/local/execution.py Tue Jan 29
05:27:23 2013
@@ -171,7 +171,7 @@
[os.path.abspath(os.path.join(self.context.shell_dir, shell))] +
d8testflag +
test.suite.GetFlagsForTestCase(test, self.context) +
- [self.context.extra_flags])
+ self.context.extra_flags)
return cmd
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
