Revision: 13540
Author: [email protected]
Date: Tue Jan 29 06:39:09 2013
Log: profiler: log solib addresses unconditionally
Make --prof_lazy log the addresses of shared libraries. Without those
addresses,
the output of the tick processor is not very useful for node.js
applications.
Address logging was disabled for --prof-lazy in r3154 for reasons that no
longer
apply: the profiler is started on demand and hence looking up the addresses
is
deferred until it's actually necessary.
Review URL: https://codereview.chromium.org/11309007
Patch from Ben Noordhuis <[email protected]>.
http://code.google.com/p/v8/source/detail?r=13540
Modified:
/branches/bleeding_edge/src/log.cc
=======================================
--- /branches/bleeding_edge/src/log.cc Mon Jan 28 05:55:40 2013
+++ /branches/bleeding_edge/src/log.cc Tue Jan 29 06:39:09 2013
@@ -209,11 +209,7 @@
if (engaged_) return;
engaged_ = true;
- // TODO(mnaganov): This is actually "Chromium" mode. Flags need to be
revised.
- // http://code.google.com/p/v8/issues/detail?id=487
- if (!FLAG_prof_lazy) {
- OS::LogSharedLibraryAddresses();
- }
+ OS::LogSharedLibraryAddresses();
// Start thread processing the profiler buffer.
running_ = true;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
