LGTM. I like the second approach much better than the one in the first
patch-set. Just nits.
https://chromiumcodereview.appspot.com/12084066/diff/7/src/objects-visiting-inl.h
File src/objects-visiting-inl.h (right):
https://chromiumcodereview.appspot.com/12084066/diff/7/src/objects-visiting-inl.h#newcode401
src/objects-visiting-inl.h:401: // non-empty descriptor array is marked,
its header is also marked. The slot
s/its header is also marked/its header is also visited/
https://chromiumcodereview.appspot.com/12084066/diff/7/src/objects-visiting-inl.h#newcode408
src/objects-visiting-inl.h:408: descriptors->GetFirstElementAddress(),
Indent by 4 instead of 2 characters.
https://chromiumcodereview.appspot.com/12084066/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
