LGTM (just a few nits).
https://chromiumcodereview.appspot.com/12047044/diff/16001/src/mark-compact.h
File src/mark-compact.h (right):
https://chromiumcodereview.appspot.com/12047044/diff/16001/src/mark-compact.h#newcode693
src/mark-compact.h:693: void MarkInParallel();
This is getting clunky, can we group these functions into a "// Parallel
sweeping support." and a "// Parallel marking support." section?
https://chromiumcodereview.appspot.com/12047044/diff/16001/src/marking-thread.cc
File src/marking-thread.cc (right):
https://chromiumcodereview.appspot.com/12047044/diff/16001/src/marking-thread.cc#newcode1
src/marking-thread.cc:1: // Copyright 2012 the V8 project authors. All
rights reserved.
2013
https://chromiumcodereview.appspot.com/12047044/diff/16001/src/marking-thread.h
File src/marking-thread.h (right):
https://chromiumcodereview.appspot.com/12047044/diff/16001/src/marking-thread.h#newcode1
src/marking-thread.h:1: // Copyright 2012 the V8 project authors. All
rights reserved.
2013
https://chromiumcodereview.appspot.com/12047044/diff/16001/src/marking-thread.h#newcode38
src/marking-thread.h:38: #include "heap.h"
Is it possible to alpha-sort the includes or does that cause dependency
errors?
https://chromiumcodereview.appspot.com/12047044/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
