LGTM. 2 comments on some of the offset math for StubFailureTrampolineFrames.
https://codereview.chromium.org/12093089/diff/15001/src/frames.cc
File src/frames.cc (right):
https://codereview.chromium.org/12093089/diff/15001/src/frames.cc#newcode1311
src/frames.cc:1311: fp() + StandardFrameConstants::kMarkerOffset - 3 *
kPointerSize);
A StubFailureTrampolineFrameConstant would be a nice aid for this
expression.
https://codereview.chromium.org/12093089/diff/15001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/12093089/diff/15001/src/ia32/code-stubs-ia32.cc#newcode7639
src/ia32/code-stubs-ia32.cc:7639: 2 * kPointerSize));
Would it make sense to having something like a
StubFailureTrampolineConstants::kArgumentCountOffset for this
expression?
https://codereview.chromium.org/12093089/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
