Reviewers: Yang,
Message:
I forgot a tiny change in string.js
Also, I'm now using the preprocessor variable in webkit, so it needs to
stay
Description:
Enable Latin-1
[email protected]
BUG=
Please review this at https://codereview.chromium.org/12039038/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M build/common.gypi
M include/v8.h
M src/string.js
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index
3a596399d69686d32a4ffe9e26849244f59264e5..b0ef4b86bbc202a26ce3f21fa51223b4e2f6f42d
100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -73,7 +73,7 @@
# Default arch variant for MIPS.
'mips_arch_variant%': 'mips32r2',
- 'v8_enable_latin_1%': 0,
+ 'v8_enable_latin_1%': 1,
'v8_enable_debugger_support%': 1,
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index
bf3beff5f0d22a56efc7756845b34ffac130138b..45c670077a1aa36f98db6c3e4bf422bc8deb8b16
100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -40,6 +40,8 @@
// TODO(svenpanne) Remove me when the Chrome bindings are adapted.
#define V8_DISABLE_DEPRECATIONS 1
+// TODO(dcarney): Remove once Latin-1 transitions in WebKit has stuck.
+#define V8_ONE_BYTE_STRINGS_ENABLED 1
#include "v8stdint.h"
Index: src/string.js
diff --git a/src/string.js b/src/string.js
index
b39976c51ed8a15332eccabecc2d1c34e26cf962..1675d0934137ad28ad99dc9a18d120fc8643e180
100644
--- a/src/string.js
+++ b/src/string.js
@@ -838,8 +838,7 @@ function StringFromCharCode(code) {
var code = %_Arguments(i);
if (!%_IsSmi(code)) code = ToNumber(code) & 0xffff;
if (code < 0) code = code & 0xffff;
- // TODO(dcarney): Fix for Latin-1.
- if (code > 0x7f) break;
+ if (code > 0xff) break;
%_OneByteSeqStringSetChar(one_byte, i, code);
}
if (i == n) return one_byte;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
