Revision: 13583
Author: [email protected]
Date: Mon Feb 4 02:30:54 2013
Log: Make the arm port build cleanly with Clang.
This fixes the following two warnings, so that "make all" builds cleanly
with Clang:
src/arm/macro-assembler-arm.h:1410:7: error: private field
'instructions_' is not used
[-Werror,-Wunused-private-field]
int instructions_; // Number of instructions of the expected
patch size.
^
src/arm/simulator-arm.cc:402:20: error: variable 'words' is used
uninitialized whenever 'if'
condition is false [-Werror,-Wsometimes-uninitialized]
} else if (argc == next_arg + 1) {
^~~~~~~~~~~~~~~~~~~~
../src/arm/simulator-arm.cc:407:21: note: uninitialized use occurs here
end = cur + words;
^~~~~
../src/arm/simulator-arm.cc:402:16: note: remove the 'if' if its
condition is always true
} else if (argc == next_arg + 1) {
^~~~~~~~~~~~~~~~~~~~~~~~~~
Review URL: https://chromiumcodereview.appspot.com/12087131
http://code.google.com/p/v8/source/detail?r=13583
Modified:
/branches/bleeding_edge/src/arm/macro-assembler-arm.cc
/branches/bleeding_edge/src/arm/macro-assembler-arm.h
/branches/bleeding_edge/src/arm/simulator-arm.cc
=======================================
--- /branches/bleeding_edge/src/arm/macro-assembler-arm.cc Fri Feb 1
03:57:22 2013
+++ /branches/bleeding_edge/src/arm/macro-assembler-arm.cc Mon Feb 4
02:30:54 2013
@@ -3952,7 +3952,6 @@
CodePatcher::CodePatcher(byte* address, int instructions)
: address_(address),
- instructions_(instructions),
size_(instructions * Assembler::kInstrSize),
masm_(NULL, address, size_ + Assembler::kGap) {
// Create a new macro assembler pointing to the address of the code to
patch.
=======================================
--- /branches/bleeding_edge/src/arm/macro-assembler-arm.h Wed Jan 23
08:29:48 2013
+++ /branches/bleeding_edge/src/arm/macro-assembler-arm.h Mon Feb 4
02:30:54 2013
@@ -1407,7 +1407,6 @@
private:
byte* address_; // The address of the code being patched.
- int instructions_; // Number of instructions of the expected patch size.
int size_; // Number of bytes of the expected patch size.
MacroAssembler masm_; // Macro assembler used to generate the code.
};
=======================================
--- /branches/bleeding_edge/src/arm/simulator-arm.cc Wed Jan 30 01:50:25
2013
+++ /branches/bleeding_edge/src/arm/simulator-arm.cc Mon Feb 4 02:30:54
2013
@@ -399,7 +399,7 @@
int32_t words;
if (argc == next_arg) {
words = 10;
- } else if (argc == next_arg + 1) {
+ } else {
if (!GetValue(argv[next_arg], &words)) {
words = 10;
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
