Revision: 13586
Author: [email protected]
Date: Mon Feb 4 05:12:03 2013
Log: Tag stubs that rely on instance types as MEGAMORPHIC.
BUG=chromium:173974
Review URL: https://chromiumcodereview.appspot.com/12178017
http://code.google.com/p/v8/source/detail?r=13586
Added:
/branches/bleeding_edge/test/mjsunit/regress/regress-crbug-173974.js
Modified:
/branches/bleeding_edge/src/builtins.h
/branches/bleeding_edge/src/code-stubs.h
=======================================
--- /dev/null
+++ /branches/bleeding_edge/test/mjsunit/regress/regress-crbug-173974.js
Mon Feb 4 05:12:03 2013
@@ -0,0 +1,36 @@
+// Copyright 2013 the V8 project authors. All rights reserved.
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+// * Redistributions of source code must retain the above copyright
+// notice, this list of conditions and the following disclaimer.
+// * Redistributions in binary form must reproduce the above
+// copyright notice, this list of conditions and the following
+// disclaimer in the documentation and/or other materials provided
+// with the distribution.
+// * Neither the name of Google Inc. nor the names of its
+// contributors may be used to endorse or promote products derived
+// from this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+// Flags: --allow-natives-syntax
+
+function f() {
+ var count = "";
+ count[0] --;
+}
+f();
+%OptimizeFunctionOnNextCall(f);
+f();
=======================================
--- /branches/bleeding_edge/src/builtins.h Tue Jan 29 04:00:56 2013
+++ /branches/bleeding_edge/src/builtins.h Mon Feb 4 05:12:03 2013
@@ -145,7 +145,7 @@
Code::kNoExtraICState) \
V(KeyedLoadIC_Generic, KEYED_LOAD_IC, GENERIC, \
Code::kNoExtraICState) \
- V(KeyedLoadIC_String, KEYED_LOAD_IC, MONOMORPHIC, \
+ V(KeyedLoadIC_String, KEYED_LOAD_IC, MEGAMORPHIC, \
Code::kNoExtraICState) \
V(KeyedLoadIC_IndexedInterceptor, KEYED_LOAD_IC, MONOMORPHIC, \
Code::kNoExtraICState) \
=======================================
--- /branches/bleeding_edge/src/code-stubs.h Mon Feb 4 04:01:59 2013
+++ /branches/bleeding_edge/src/code-stubs.h Mon Feb 4 05:12:03 2013
@@ -549,7 +549,12 @@
public:
explicit ICStub(Code::Kind kind) : kind_(kind) { }
virtual int GetCodeKind() { return kind_; }
- virtual InlineCacheState GetICState() { return MONOMORPHIC; }
+ // Currently all IC stubs do not collect explicit type feedback but
rather
+ // check the instance type.
+ // TODO(verwaest): These stubs should collect proper type feedback, and
should
+ // not check the instance type explicitly (perhaps unless more than
+ // kMaxPolymorphism maps are recorded).
+ virtual InlineCacheState GetICState() { return MEGAMORPHIC; }
bool Describes(Code* code) {
return GetMajorKey(code) == MajorKey() && code->stub_info() ==
MinorKey();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
