Reviewers: Jakob,
Message:
PTAL
Description:
Keep ArrayLength, StringLength and FunctionPrototype MONOMORPHIC.
Please review this at https://chromiumcodereview.appspot.com/12181012/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/code-stubs.h
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index
dde0cc29b08296e764288f94da6b0deb198ef409..1b160c40fa0495af5119e7b7eeaa77379d4cb213
100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -549,12 +549,7 @@ class ICStub: public PlatformCodeStub {
public:
explicit ICStub(Code::Kind kind) : kind_(kind) { }
virtual int GetCodeKind() { return kind_; }
- // Currently all IC stubs do not collect explicit type feedback but
rather
- // check the instance type.
- // TODO(verwaest): These stubs should collect proper type feedback, and
should
- // not check the instance type explicitly (perhaps unless more than
- // kMaxPolymorphism maps are recorded).
- virtual InlineCacheState GetICState() { return MEGAMORPHIC; }
+ virtual InlineCacheState GetICState() { return MONOMORPHIC; }
bool Describes(Code* code) {
return GetMajorKey(code) == MajorKey() && code->stub_info() ==
MinorKey();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.