On 2013/02/06 10:49:07, Net147 wrote:
On 2013/02/06 10:47:50, Yang wrote:
> On 2013/02/06 10:39:52, Net147 wrote:
> > On 2013/02/06 10:34:24, Yang wrote:
> > > On 2013/02/04 13:04:49, Net147 wrote:
> > >
> > > I'm confused. Is v8_localtime_s et al. something that MinGW
provides?
> >
> > Nope. It's so the functions don't conflict if MinGW defines
localtime_s,
> > fopen_s, etc. in its headers.
>
> So if I understood correctly, the current behavior is that when
> MINGW_HAS_SECURE_API is not defined, we define our own set of *_s
functions.
> Otherwise, we rely on the ones provided by msvcrt.dll.
>
> The CL changes so that we always use our own set of *_s functions. The
reason
> being that while newer msvcrt.dll provides those *_s functions, the one
in
> Windows XP does not.
>
> Is that correct?
Yes.
LGTM. Landing.
https://codereview.chromium.org/12189010/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
