Extended the work to replace all JumpIfSmi+CheckPrototypes in LoadICs with
HandlerFrontends. Added extra comments inline.
https://chromiumcodereview.appspot.com/12209021/diff/5/src/ia32/stub-cache-ia32.cc
File src/ia32/stub-cache-ia32.cc (right):
https://chromiumcodereview.appspot.com/12209021/diff/5/src/ia32/stub-cache-ia32.cc#newcode1047
src/ia32/stub-cache-ia32.cc:1047: void
BaseLoadStubCompiler::GenerateDictionaryLoadCallback(
This got moved into CallbackHandlerFrontend directly.
https://chromiumcodereview.appspot.com/12209021/diff/5/src/ia32/stub-cache-ia32.cc#newcode2721
src/ia32/stub-cache-ia32.cc:2721:
Use other register so it looks exactly the same as another
JumpIfSmi/CheckPrototype combination.
https://chromiumcodereview.appspot.com/12209021/diff/7001/src/ia32/stub-cache-ia32.cc
File src/ia32/stub-cache-ia32.cc (right):
https://chromiumcodereview.appspot.com/12209021/diff/7001/src/ia32/stub-cache-ia32.cc#newcode3091
src/ia32/stub-cache-ia32.cc:3091: Label success, miss;
Kept the header/footer and stuff in between inlined, rather than
generating a special Frontend, since the body of this method doesn't do
anything else than return after the frontend succeeds. There won't be
any point in jumping to a shared stub that just returns.
https://chromiumcodereview.appspot.com/12209021/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
