On 2013/02/07 15:28:35, Jakob wrote:
Fix for the second problem that CryptoJS exposed. Please take a look.
https://codereview.chromium.org/12223039/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (left):
https://codereview.chromium.org/12223039/diff/1/src/ia32/code-stubs-ia32.cc#oldcode1856
src/ia32/code-stubs-ia32.cc:1856: // right optimized code, int32 type
feedback
is just right.
Yeah, well, turns out it's not quite right after all :-)
https://codereview.chromium.org/12223039/diff/1/src/ia32/code-stubs-ia32.cc#oldcode2802
src/ia32/code-stubs-ia32.cc:2802: return;
Who are we kidding?
https://codereview.chromium.org/12223039/diff/1/src/ia32/code-stubs-ia32.cc#oldcode3001
src/ia32/code-stubs-ia32.cc:3001: void
FloatingPointHelper::CheckFloatOperandsAreInt32(MacroAssembler* masm,
This seems rather similar in functionality to
FloatingPointHelper::CheckLoadedIntegersWereInt32, maybe the two should be
refactored and combined?
https://codereview.chromium.org/12223039/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/12223039/diff/1/src/ia32/code-stubs-ia32.cc#newcode920
src/ia32/code-stubs-ia32.cc:920: static void
ConvertHeapNumberToInt32(MacroAssembler* masm,
Basically a drop-in replacement for IntegerConvert() above, except that it
jumps
to |conversion_failure| when the heap number did not have an int32 value.
We use SSE2 xmm-to-register conversions all over the place, I don't think
it
hurts here performance-wise.
...I'll update the method's comment before landing.
https://codereview.chromium.org/12223039/diff/1/src/ia32/code-stubs-ia32.cc#newcode2254
src/ia32/code-stubs-ia32.cc:2254: BinaryOpIC::GENERIC,
Strictly speaking, this is inconsistent, but it doesn't seem to hurt
currently.
Postponing the cleanup to when we hydrogen-generate this stub.
LGTM
https://codereview.chromium.org/12223039/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
