LGTM with a nit and a suggestion.
https://codereview.chromium.org/12207076/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/12207076/diff/1/src/api.cc#newcode4420
src/api.cc:4420: heap_statistics->Clear();
Since there is only one use of the Clear() method besides the
constructor, and that is in a deprecated method, one could even argue to
remove the Clear() method completely. But I'll leave that up to you.
https://codereview.chromium.org/12207076/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/12207076/diff/1/test/cctest/test-api.cc#newcode15204
test/cctest/test-api.cc:15204: LocalContext c1;
I know it's not your change, but can we rename the LocalContext to
either "context" or "env", that's in line with the rest of the code.
https://codereview.chromium.org/12207076/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
