Reviewers: danno,
Message:
Hi,
Can you please take a look?
This is a very minimal change on a non-critical code path so I hope we can
get
it in before branch point.
Description:
Print deoptimization index when printing lithium environment.
Output of --trace-deopt --code-comments does not always allow to reliably
match
deoptimization to the lithium instruction (and it is actually never
accurate on
x64 due to one level of indirection). This change allows to reliably figure
out
which instruction deoptimized just by looking up bailout id in the
hydrogen.cfg.
[email protected]
BUG=
Please review this at https://codereview.chromium.org/12217103/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/lithium.cc
Index: src/lithium.cc
diff --git a/src/lithium.cc b/src/lithium.cc
index
5967e429a97c318d6ae0e90437e105a929379cf8..e943cc068544a1e4d58b3890cb77df0072876eb6
100644
--- a/src/lithium.cc
+++ b/src/lithium.cc
@@ -174,6 +174,9 @@ void LParallelMove::PrintDataTo(StringStream* stream)
const {
void LEnvironment::PrintTo(StringStream* stream) {
stream->Add("[id=%d|", ast_id().ToInt());
+ if (deoptimization_index() != Safepoint::kNoDeoptimizationIndex) {
+ stream->Add("deopt_id=%d|", deoptimization_index());
+ }
stream->Add("[parameters=%d|", parameter_count());
stream->Add("[arguments_stack_height=%d|", arguments_stack_height());
for (int i = 0; i < values_.length(); ++i) {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
