https://chromiumcodereview.appspot.com/12208013/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://chromiumcodereview.appspot.com/12208013/diff/1/src/hydrogen-instructions.cc#newcode2973
src/hydrogen-instructions.cc:2973: HInstruction::Verify();
On 2013/02/07 16:17:14, Jakob wrote:
On 2013/02/06 19:12:31, Massi wrote:
> The linker complains if I don't override it (and implement it).
Not for me. Maybe you've forgotten to remove the declaration from the
class
definition in hydrogen-instructions.h?
I was sure I had deleted, but I did not :-/
Done :-)
https://chromiumcodereview.appspot.com/12208013/diff/5001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://chromiumcodereview.appspot.com/12208013/diff/5001/src/code-stubs-hydrogen.cc#newcode180
src/code-stubs-hydrogen.cc:180: AddInstruction(
On 2013/02/07 16:17:14, Jakob wrote:
Please add a comment here:
// Since we're forcing Integer32 representation for this HBoundsCheck,
// there's no need to Smi-check the index.
Done.
https://chromiumcodereview.appspot.com/12208013/diff/5001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://chromiumcodereview.appspot.com/12208013/diff/5001/src/hydrogen-instructions.cc#newcode2395
src/hydrogen-instructions.cc:2395: HInferRepresentation* h_infer) {
On 2013/02/07 16:17:14, Jakob wrote:
nit: fits on one line now.
Done.
https://chromiumcodereview.appspot.com/12208013/diff/5001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://chromiumcodereview.appspot.com/12208013/diff/5001/src/hydrogen-instructions.h#newcode3117
src/hydrogen-instructions.h:3117: class HGraphBuilder;
On 2013/02/07 16:17:14, Jakob wrote:
still there?
Done.
https://chromiumcodereview.appspot.com/12208013/diff/5001/src/hydrogen-instructions.h#newcode3127
src/hydrogen-instructions.h:3127: HBoundsCheck(HValue* index, HValue*
length,
On 2013/02/07 16:17:14, Jakob wrote:
nit: in function/method/ctor definitions (as opposed to calls), each
argument
gets its own line (unless everything including the function name fits
onto a
single line).
Done.
https://chromiumcodereview.appspot.com/12208013/diff/5001/src/hydrogen-instructions.h#newcode3130
src/hydrogen-instructions.h:3130: : key_mode_(key_mode),
skip_check_(false) {
On 2013/02/07 16:17:14, Jakob wrote:
nit: now I want less indentation here :-)
(the ':' gets 4 spaces relative to 'HBoundsCheck(').
Done.
https://chromiumcodereview.appspot.com/12208013/diff/5001/src/hydrogen-instructions.h#newcode3155
src/hydrogen-instructions.h:3155: virtual void PrintDataTo(StringStream*
stream);
On 2013/02/07 16:17:14, Jakob wrote:
I don't see an implementation of this. I guess overriding it is not
needed at
all.
HBoundsCheck::PrintDataTo and HBoundsCheck::InferRepresentation are both
implemented.
https://chromiumcodereview.appspot.com/12208013/diff/5001/src/hydrogen.h
File src/hydrogen.h (right):
https://chromiumcodereview.appspot.com/12208013/diff/5001/src/hydrogen.h#newcode878
src/hydrogen.h:878: HBoundsCheck* AddBoundsCheck(
On 2013/02/07 16:17:14, Jakob wrote:
Since this is not used for stubs, please move it to
HOptimizedGraphBuilder.
I tried, but it is used in
HGraphBuilder::BuildUncheckedMonomorphicElementAccess.
https://chromiumcodereview.appspot.com/12208013/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
