Very close. If you address my last comment (sorry, I realize it deviates
slightly from my last round of comments, I apologize for that), then I think
this is ready to land.
https://codereview.chromium.org/12223027/diff/13003/src/log.h
File src/log.h (right):
https://codereview.chromium.org/12223027/diff/13003/src/log.h#newcode381
src/log.h:381: Handle<Script> script,
Sorry, I think I gave you slightly misleading advice in the last set of
comments. It does appear that the Issue APIs take "naked" object
pointers. So do indeed pass a Script* here (sorry!!) for consistency
with the other issue API. However, still clean up how the Handle is
cobbled together in the implementation of IssueCodeAddedEvent. Please
move the logic that you now have at the call sites of
IssueCodeAddedEvent that creates a Handle<Script> into
IssueCodeAddedEvent to make the handle right before you do the ToApi
call.
https://codereview.chromium.org/12223027/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
