Reviewers: Jakob, danno, kisg, palfia,
Message:
Hi Jakob - Fixing a case where the m32 flag is passed incorrectly to the
mips
cross toolchain when the CXX vars are not in the environment. PTAL, and let
me
know if you have a better approach.
Description:
MIPS: Fix mips gyp build for chromium.
Our planned CL for the Chromium build system passes the toolchain
vars though the Makefiles, so that we do not depend on $CXX, etc.,
in the environment.
That causes a problem with deriving the 'm32flag' in v8 gyp.
This patch lets us build with or without the toolchain vars in
the environment.
BUG=
Please review this at https://codereview.chromium.org/12218113/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M build/common.gypi
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index
3a596399d69686d32a4ffe9e26849244f59264e5..9393b498dff3cd426422e48b3b607169a3735a99
100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -205,7 +205,7 @@
'mipscompiler': '<!($(echo ${CXX:-$(which g++)}) -v 2>&1 | grep
-q "^Target: mips" && echo "yes" || echo "no")',
},
'conditions': [
- ['mipscompiler=="yes"', {
+ ['mipscompiler=="yes" or host_arch!=target_arch', {
'target_conditions': [
['_toolset=="target"', {
'cflags': ['-EL'],
@@ -324,7 +324,7 @@
'clang%': 0,
},
'conditions': [
- ['OS!="android" or clang==1', {
+ ['(OS!="android" or clang==1) and (host_arch==target_arch)',
{
'cflags': [ '<(m32flag)' ],
'ldflags': [ '<(m32flag)' ],
}],
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
