Reviewers: Jakob,
Message:
PTAL
Description:
Calculate proper receiver map for monomorphic transitioning ICs.
This fixes a regression caused by
https://chromiumcodereview.appspot.com/11953025/
Please review this at https://chromiumcodereview.appspot.com/12217131/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/ic.cc
Index: src/ic.cc
diff --git a/src/ic.cc b/src/ic.cc
index
b74b0d966afccd2dc5d3925d11c77b2c8ffca907..e19edfc9e775f49bec1330ca1085356612be171e
100644
--- a/src/ic.cc
+++ b/src/ic.cc
@@ -1544,9 +1544,10 @@ Handle<Code>
KeyedStoreIC::StoreElementStub(Handle<JSObject> receiver,
if (ic_state == UNINITIALIZED || ic_state == PREMONOMORPHIC) {
// Optimistically assume that ICs that haven't reached the MONOMORPHIC
state
// yet will do so and stay there.
+ Handle<Map> monomorphic_map = ComputeTransitionedMap(receiver,
stub_kind);
stub_kind = GetNoTransitionStubKind(stub_kind);
return isolate()->stub_cache()->ComputeKeyedStoreElement(
- receiver_map, stub_kind, strict_mode, grow_mode);
+ monomorphic_map, stub_kind, strict_mode, grow_mode);
}
GetReceiverMapsForStub(Handle<Code>(target()), &target_receiver_maps);
@@ -1633,8 +1634,7 @@ Handle<Map>
KeyedStoreIC::ComputeTransitionedMap(Handle<JSObject> receiver,
FAST_HOLEY_DOUBLE_ELEMENTS);
case STORE_NO_TRANSITION:
case STORE_AND_GROW_NO_TRANSITION:
- UNREACHABLE();
- break;
+ return Handle<Map>(receiver->map());
}
return Handle<Map>::null();
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
