Generally LGTM, but I do have a question (see below).
I guess one of the next steps will be to fix the tests. I'd like to remind
you
that test.py and test-wrapper-gypbuild.py are deprecated and will be deleted
soon. Instead, you'll have to update tools/run-tests.py,
tools/testrunner/local/statusfile.py, and most of the
test/$SUITE/$SUITE.status
files (never mind their .status2 counterparts, those are auto-generated).
https://codereview.chromium.org/12248014/diff/1/build/android.gypi
File build/android.gypi (right):
https://codereview.chromium.org/12248014/diff/1/build/android.gypi#newcode163
build/android.gypi:163: ['target_arch=="mipsel"', {
Are you sure this block of changes is necessary? We already have the
same settings in common.gypi, that should be enough to have them apply
to Android build targets too.
https://codereview.chromium.org/12248014/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
